Fix null handling for Arrow data#6227
Merged
jameslamb merged 2 commits intomicrosoft:masterfrom Dec 6, 2023
borchero:fix-null
Merged
Fix null handling for Arrow data#6227jameslamb merged 2 commits intomicrosoft:masterfrom borchero:fix-null
jameslamb merged 2 commits intomicrosoft:masterfrom
borchero:fix-null
Conversation
borchero
requested review from
guolinke,
jameslamb,
jmoralez and
shiyu1994
as code owners
guolinke
approved these changes
Dec 6, 2023
jameslamb
approved these changes
Dec 6, 2023
Collaborator
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
thanks for catching it!
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I realized that we didn't add a test for Arrow data with NULLs. Turns out, the condition to identify NULLs was faulty (which wasn't apparent before since no nullability bitmask is created if no element is NULL).
Unfortunately, the existing C++ test (where we built the Arrow array manually) was also faulty which didn't catch the issue in the first place...