Conversation
borchero
approved these changes
Feb 16, 2024
Collaborator
Author
|
@shiyu1994 can you please restart the VM running for the CUDA jobs? Seems those jobs are getting stuck waiting for a runner to pick them up. |
Collaborator
Author
|
thanks for the help @shiyu1994 |
jameslamb
added a commit
that referenced
this pull request
Feb 19, 2024
I just learned that GitHub Action `lee-dohm/no-response` doesn't support `workflow_dispatch` events: #6313 (comment) This reverts that addition from #6323.
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #6313
How to test this
I think we'll have to merge this PR to test, since
workflow_dispatch(the thing that lets you click a button and run it from an arbitrary branch) isn't set up for this workflow.In this PR, I'm also proposing adding a
workflow_dispatchtrigger, so we can do that type of testing in the future if needed.Notes for Reviewers
Looks like the lock-bot config already uses this:
LightGBM/.github/workflows/lock.yml
Lines 10 to 12 in 6330d62
And it shouldn't affect triggering-comments stuff like the
valgrindchecks, as those use a different secret:LightGBM/.github/workflows/triggering_comments.yml
Lines 11 to 12 in 6330d62