[ci] put ceiling on graphviz in Python 3.7 jobs#6370
Merged
Conversation
5 tasks
Collaborator
Author
|
absolutely BRUTAL week for our CI 😭 |
Collaborator
|
Let's go? 😄 this should unblock a lot of CI 👀 |
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.7 CI jobs are failing with this error:
Example recent build from
master: (build link).python-graphvizhas a floor ofpython>=3.8since xflr6/graphviz#202, but I guess that hasn't extended to theconda-forgepackage. That results in a newer version ofpython-graphvizbeing pulled into a Python 3.7 environment which contains invalid syntax for Python 3.7.This PR proposes putting a ceiling on
python-graphvizin LightGBM's Python 3.7 CI jobs.Notes for Reviewers
Looks like this is the result of the latest
python-graphvizrelease on conda-forge about 4 hours ago: conda-forge/python-graphviz-feedstock#55.I don't think conda-forge will be interested in a repodata patch to prevent this from happening, so I'm not planning to propose one. Based on this evidence:
I did put up conda-forge/python-graphviz-feedstock#56 proposing adding a
python>=3.8floor on conda-forge, so maybe if that's merged we could eventually remove this ceiling in CI scripts.If this ceiling on
python-graphvizcauses problems in the future, I'd support turning off the plotting tests for Python 3.7 environments.