Skip to content

upgrade CMake in dockerfile-cli (fixes #6420)#6426

Merged
jameslamb merged 2 commits intomicrosoft:masterfrom
narumiruna:fix-docker
Apr 30, 2024
Merged

upgrade CMake in dockerfile-cli (fixes #6420)#6426
jameslamb merged 2 commits intomicrosoft:masterfrom
narumiruna:fix-docker

Conversation

@narumiruna
Copy link
Contributor

@narumiruna narumiruna commented Apr 24, 2024

$ docker build -t lightgbm-cli -f dockerfile-cli .

14.05 CMake Error at CMakeLists.txt:30 (cmake_minimum_required):
14.05   CMake 3.18 or higher is required.  You are running version 3.16.3

This PR upgrades CMake to the newest version.

@jameslamb jameslamb added the fix label Apr 24, 2024
@jameslamb jameslamb changed the title Fix dockerfile-cli upgrade to Ubuntu 22.04 in dockerfile-cli (fixes #6420) Apr 24, 2024
@jameslamb jameslamb changed the title upgrade to Ubuntu 22.04 in dockerfile-cli (fixes #6420) upgrade CMake in dockerfile-cli (fixes #6420) Apr 24, 2024
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much! This looks good to me. I think it'll fix #6420, so I've added that to the description.

In the near future, we'll added automated tests on these Dockerfiles to prevent issues like this from arising in the future.

@jameslamb jameslamb merged commit d7fcb3c into microsoft:master Apr 30, 2024
@jameslamb
Copy link
Collaborator

Thanks very much, we'd love to have you come contribute more in the future!

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants