[python-package] add a few type hints in LGBMModel.fit()#6470
Merged
[python-package] add a few type hints in LGBMModel.fit()#6470
Conversation
jameslamb
requested review from
borchero,
guolinke,
jmoralez and
shiyu1994
as code owners
borchero
reviewed
Jun 2, 2024
borchero
approved these changes
Jun 5, 2024
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #3867
Contributes to #3756
Pulls a function re-defined on every call to
LGBMModel.fit()up to the module level, and adds type hints, a docstring, and comments to make it easier to understand and to improvemypy's ability to catch bugs on codepaths that go through it.Resolves this error from
mypy: