[CMake] Use CMAKE_MSVC_RUNTIME_LIBRARY to apply /MT#6484
Merged
jameslamb merged 9 commits intomicrosoft:masterfrom Jul 4, 2024
Merged
[CMake] Use CMAKE_MSVC_RUNTIME_LIBRARY to apply /MT#6484jameslamb merged 9 commits intomicrosoft:masterfrom
jameslamb merged 9 commits intomicrosoft:masterfrom
Conversation
hcho3
requested review from
borchero,
guolinke,
jameslamb,
jmoralez and
shiyu1994
as code owners
hcho3
commented
Jun 14, 2024
jameslamb
requested changes
Jun 17, 2024
Collaborator
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Looks good to me! Just left one small request to move this code back down inside the if(BUILD_CPP_TEST) block.
Don't worry about the failing CI jobs... they're flaky and the failures are unrelated to your changes.
jameslamb
reviewed
Jun 20, 2024
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the built-in flag
CMAKE_MSVC_RUNTIME_LIBRARYin CMake to robustly handle the linking mode for the Windows C runtime (/MDvs/MT). See https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html