[ci] remove OpenMP / MKL workaround in CI jobs#6496
Merged
Conversation
borchero
approved these changes
Jun 21, 2024
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposes removing a workaround in CI scripts that has been in place since #1606.
The code removed here sets up some symlinks that make it look like, for example,
libgomp.dylib(GNU OpenMP) islibomp.dylib(the SONAME used by LLVM OpenMP). This was a workaround for some conflicts between OpenMP implementations that were showing up together (I think).Removing it to simplify CI scripts, and because:
libomp.dylibinto an process that already has one loaded)libomp, LLVM OpenMP)Notes for Reviewers
For more conversation on this, see #6489.