[R-package]: add num_trees_per_iter, num_trees, and num_iter methods#6500
Merged
jameslamb merged 4 commits intomicrosoft:masterfrom Jul 3, 2024
Merged
[R-package]: add num_trees_per_iter, num_trees, and num_iter methods#6500jameslamb merged 4 commits intomicrosoft:masterfrom
jameslamb merged 4 commits intomicrosoft:masterfrom
Conversation
jameslamb
requested changes
Jun 21, 2024
Collaborator
jameslamb
left a comment
There was a problem hiding this comment.
Thanks very much! I support adding these methods on the Booster and not also adding new exported functions for them. And the tests look great.
Will you please just consider my recommendation to use the language "trees" instead of "models"?
jmoralez
approved these changes
Jun 24, 2024
Collaborator
|
Thanks @jmoralez ! I'll look into the failing CI and merge this. |
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds to the R Booster class the following methods:
Two functions from the C API are required:
LGBM_BoosterNumModelPerIteration_R()viaLGBM_BoosterNumModelPerIteration()andLGBM_BoosterNumberOfTotalModel_R()viaLGBM_BoosterNumberOfTotalModel()This additionally helps to solve #6380.
Note: With early stopping, the number of (relevant) iterations is kept in
Booster$best_iter, whilenum_trees()andnum_iter()are higher.