[ci] fix some shellcheck errors in scripts by shreyash2002 · Pull Request #6504 · microsoft/LightGBM

shreyash2002 · 2024-06-24T06:44:15Z

Contributes to #6498

fixed SC0286 (info): Double quote to prevent globbing and word splitting

…icrosoft#6498) - Errors- SC2086 (info) : Double quote to prevent globbing and word splitting

…t#6498) - Fixed SC2086 (info): Double quote to prevent globbing and word splitting.

…icrosoft#6498) - fixed SC2086 (info): Double quote to prevent globbing and word splitting.

shreyash2002 · 2024-06-24T06:44:56Z

@microsoft-github-policy-service agree

shreyash2002 · 2024-06-24T06:56:09Z

hi @jameslamb
i've resolved shellchecks check error in three files. all of them had SC0286 check error.

jameslamb

Thanks for taking the time to contribute to LightGBM!

I've requested some changes here. I've also made some edits:

removed fixed #6498 from the PR title... this does not FIX that issue, it just helps make some progress towards it
added a link to #6498 in the PR description... please always do this when you contribute here and your contribution relates to other discussions in the project

.ci/install-clang-devel.sh

- Used double quotes around entire word as suggested - microsoft#6498

jameslamb

thanks for your help, please see my recent suggestions

jameslamb · 2024-06-28T01:34:35Z

.ci/install-clang-devel.sh

+    "llvm-${CLANG_VERSION}"-dev \
+    "llvm-${CLANG_VERSION}"-tools \
+    "libomp-${CLANG_VERSION}"-dev \
+    "libc++-${CLANG_VERSION}"-dev \
+    "libc++abi-${CLANG_VERSION}"-dev \
+    "libclang-common-${CLANG_VERSION}"-dev \
+    "libclang-${CLANG_VERSION}"-dev \
+    "libclang-cpp${CLANG_VERSION}"-dev \
+    "libunwind-${CLANG_VERSION}"-dev


Suggested change

"llvm-${CLANG_VERSION}"-dev \

"llvm-${CLANG_VERSION}"-tools \

"libomp-${CLANG_VERSION}"-dev \

"libc++-${CLANG_VERSION}"-dev \

"libc++abi-${CLANG_VERSION}"-dev \

"libclang-common-${CLANG_VERSION}"-dev \

"libclang-${CLANG_VERSION}"-dev \

"libclang-cpp${CLANG_VERSION}"-dev \

"libunwind-${CLANG_VERSION}"-dev

"llvm-${CLANG_VERSION}-dev" \

"llvm-${CLANG_VERSION}-tools" \

"libomp-${CLANG_VERSION}-dev" \

"libc++-${CLANG_VERSION}-dev" \

"libc++abi-${CLANG_VERSION}-dev" \

"libclang-common-${CLANG_VERSION}-dev" \

"libclang-${CLANG_VERSION}-dev" \

"libclang-cpp${CLANG_VERSION}-dev" \

"libunwind-${CLANG_VERSION}-dev"

Please don't leave quotes in the middle of these words, as I asked in #6504 (comment).

jameslamb · 2024-06-28T01:38:08Z

.ci/install-clang-devel.sh

 # overwriting the stuff in /usr/bin is simpler and more reliable than
 # updating PATH, LD_LIBRARY_PATH, etc.
-cp --remove-destination /usr/lib/llvm-${CLANG_VERSION}/bin/* /usr/bin/
+cp --remove-destination /usr/lib/llvm-"${CLANG_VERSION}"/bin/* /usr/bin/


Suggested change

cp --remove-destination /usr/lib/llvm-"${CLANG_VERSION}"/bin/* /usr/bin/

cp --remove-destination "$(echo /usr/lib/llvm-${CLANG_VERSION}/bin/*)" /usr/bin/

jameslamb · 2024-06-28T01:40:35Z

.ci/trigger_dispatch_run.sh

-    --arg pr_branch "$(echo $pr | jq '.head.ref')" \
+    --arg pr_number "$(echo "$pr" | jq '.number')" \
+    --arg pr_sha "$(echo "$pr" | jq '.head.sha')" \
+    --arg pr_branch "$(echo "$pr" | jq '.head.ref')" \


Putting double quotes inside other double quotes like this requires escaping. To avoid that, please revert these changes and instead add the following comment on line 37 (directly above data=$():

# shellcheck disable=SC0286

jameslamb · 2024-07-14T17:23:46Z

@shreyash2002 are you planning to return to this pull request? Do you need any help?

StrikerRUS · 2024-09-05T14:02:09Z

.ci/install-clang-devel.sh was removed, .ci/set_commit_status.sh and .ci/trigger_dispatch_run.sh were fixed in #6621.

@shreyash2002 Thanks for your work here! Please pick up any other issue to contribute if you wish.

github-actions · 2025-09-11T00:11:43Z

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

shreyash2002 added 3 commits June 24, 2024 11:55

[ci] enforced shellcheck checks for .ci/trigger_dispact_run.sh; Issue(m…

62da54a

…icrosoft#6498) - Errors- SC2086 (info) : Double quote to prevent globbing and word splitting

[ci] enforced shellcheck checks in .ci/set_commit_status.sh (microsof…

dfb3da2

…t#6498) - Fixed SC2086 (info): Double quote to prevent globbing and word splitting.

[ci] enforced shellcheck checks in .ci/install-clang-devel.sh issue(m…

6ee5286

…icrosoft#6498) - fixed SC2086 (info): Double quote to prevent globbing and word splitting.

shreyash2002 requested review from borchero, guolinke, jameslamb, jmoralez and shiyu1994 as code owners June 24, 2024 06:44

shreyash2002 changed the title ~~[ci] enforce shellchecks checks in (trigger_dispatch_run.sh); (set_commit_status.sh); (install_clang_devel.sh)~~ [ci] enforce shellchecks checks in (trigger_dispatch_run.sh); (set_commit_status.sh); (install_clang_devel.sh) fixes #6498 Jun 24, 2024

jameslamb changed the title ~~[ci] enforce shellchecks checks in (trigger_dispatch_run.sh); (set_commit_status.sh); (install_clang_devel.sh) fixes #6498~~ [ci] fix some shellcheck errors in scripts Jun 24, 2024

jameslamb requested changes Jun 24, 2024

View reviewed changes

.ci/install-clang-devel.sh Outdated Show resolved Hide resolved

jameslamb added in progress maintenance labels Jun 24, 2024

fix shellcheck errors in .ci/install-clang-devel.sh

1978e19

- Used double quotes around entire word as suggested - microsoft#6498

jameslamb requested changes Jun 28, 2024

View reviewed changes

jameslamb mentioned this pull request Jul 3, 2024

[ci] aarch64 python-package job failing: "cannot allocate memory in static TLS block" #6509

Closed

jameslamb added the awaiting response label Jul 4, 2024

StrikerRUS closed this Sep 5, 2024

github-actions bot removed awaiting response in progress labels Sep 11, 2025

github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ci] fix some shellcheck errors in scripts#6504

[ci] fix some shellcheck errors in scripts#6504
shreyash2002 wants to merge 4 commits intomicrosoft:masterfrom
shreyash2002:ci]-enforce-shellchecks

shreyash2002 commented Jun 24, 2024 •

edited by jameslamb

Loading

Uh oh!

shreyash2002 commented Jun 24, 2024

Uh oh!

shreyash2002 commented Jun 24, 2024

Uh oh!

jameslamb left a comment

Uh oh!

Uh oh!

jameslamb left a comment

Uh oh!

jameslamb Jun 28, 2024

Uh oh!

jameslamb Jun 28, 2024

Uh oh!

jameslamb Jun 28, 2024

Uh oh!

jameslamb commented Jul 14, 2024

Uh oh!

StrikerRUS commented Sep 5, 2024

Uh oh!

github-actions bot commented Sep 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	cp --remove-destination /usr/lib/llvm-"${CLANG_VERSION}"/bin/* /usr/bin/
	cp --remove-destination "$(echo /usr/lib/llvm-${CLANG_VERSION}/bin/*)" /usr/bin/

Conversation

shreyash2002 commented Jun 24, 2024 • edited by jameslamb Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shreyash2002 commented Jun 24, 2024

Uh oh!

shreyash2002 commented Jun 24, 2024

Uh oh!

jameslamb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jameslamb left a comment

Choose a reason for hiding this comment

Uh oh!

jameslamb Jun 28, 2024

Choose a reason for hiding this comment

Uh oh!

jameslamb Jun 28, 2024

Choose a reason for hiding this comment

Uh oh!

jameslamb Jun 28, 2024

Choose a reason for hiding this comment

Uh oh!

jameslamb commented Jul 14, 2024

Uh oh!

StrikerRUS commented Sep 5, 2024

Uh oh!

github-actions bot commented Sep 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shreyash2002 commented Jun 24, 2024 •

edited by jameslamb

Loading