[ci] restore aarch64 linux builds (fixes #6509)#6527
Merged
Conversation
StrikerRUS
approved these changes
Jul 9, 2024
Collaborator
StrikerRUS
left a comment
There was a problem hiding this comment.
🚀
Awesome research in #6509!
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6509
follow-up to #6517
Proposes:
aarch64Linux buildsscikit-learnimport earlier, to hopefully loadlibgomp.soearlierscikit-build-coreto set the wheel platform tag, instead of doing it manually withmvstatementsNotes for Reviewers
What happened to the idea of running these builds in Docker on the
macos-14runner?it isn't possible because running docker on those runners isn't possible (click me)
ref: #6509 (comment)
I was hoping to be able to use Docker on the M1 Mac runner to do aarch64 linux builds... those runners already have an arm64 CPU, so we'd be able to do builds and testing without emulation, which should be much faster.
Unfortunately, that did not work. As of this writing, that runner does not support nested virtualization, so it isn't possible to run
dockeron it. I tried withcolima, thedockerHomebrew cask, and podman.Some references:
So for now, this PR just restores the QEMU-based builds (using emulation).