[cmake] [R-package] include R-for-macOS vendored libs dir in OpenMP search path (fixes #6628)#6629
Merged
[cmake] [R-package] include R-for-macOS vendored libs dir in OpenMP search path (fixes #6628)#6629
Conversation
…earch path (fixes #6628)
jameslamb
changed the title
jameslamb
requested review from
StrikerRUS,
borchero,
guolinke,
jmoralez and
shiyu1994
as code owners
StrikerRUS
approved these changes
Aug 29, 2024
Collaborator
StrikerRUS
left a comment
StrikerRUS
left a comment
There was a problem hiding this comment.
Thanks a lot for the detailed description! Based on it everything looks good to me!
I left only one stylish suggestion, feel free to merge without applying it,
|
|
||
| # ask R for the lib dir | ||
| execute_process( | ||
| COMMAND ${LIBR_EXECUTABLE} "--slave" "--vanilla" "-e" "cat(normalizePath(R.home('lib'), winslash='/'))" |
Collaborator
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
oh wow! Ok good, that makes me feel more confident in this 😁
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6628
The background for this is described in much greater detail in #6628 (comment).
In short:
{data.table}recently put up a new release (v1.16.0)libomp.dylib{data.table}and a CMake + clang version of{lightgbm}to load 2 different copies oflibomp.dylib, causing segfaults{lightgbm}are brokenThis fixes it by ensuring that the place where R vendors third-party libraries is searched for
libomp.dylibfirst whenlibrary(lightgbm)is called (so that the same libraries used by CRAN will be found).Notes for Reviewers
Other relevant discussions: