Skip to content

[ci] add shellcheck, use latest pre-commit hook versions#6685

Merged
StrikerRUS merged 1 commit intomasterfrom
ci/shellcheck
Oct 17, 2024
Merged

[ci] add shellcheck, use latest pre-commit hook versions#6685
StrikerRUS merged 1 commit intomasterfrom
ci/shellcheck

Conversation

@jameslamb
Copy link
Collaborator

Contributes to #6498

  • enforces shellcheck checks in CI
  • updates all pre-commit hooks to their latest versions (via pre-commit autoupdate)

Fixes 1 new warning found by ruff

python-package/lightgbm/basic.py:879:17: PLR1730 [*] Replace `if` statement with `offset = max(offset, max_offset)

Notes for reviewers

Double-checked, and shellcheck-py ships wheels for Linux, Windows, and macOS ... so everyone working on the project should be able to keep running pre-commit without issue.

ref: https://pypi.org/project/shellcheck-py/#files

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, very nice!

@StrikerRUS StrikerRUS merged commit 283cdde into master Oct 17, 2024
@StrikerRUS StrikerRUS deleted the ci/shellcheck branch October 17, 2024 23:33
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants