[ci] fix errors about line length in yaml files (Part 4)#6804
[ci] fix errors about line length in yaml files (Part 4)#6804StrikerRUS merged 10 commits intomasterfrom
Conversation
| if: | | ||
| github.event.issue.pull_request && | ||
| contains('OWNER,MEMBER,COLLABORATOR', github.event.comment.author_association) && | ||
| startsWith(github.event.comment.body, '/gha run') |
There was a problem hiding this comment.
| - script: | | ||
| git clean -d -f -x | ||
| displayName: 'Clean source directory' | ||
| # yamllint disable rule:line-length |
| submodules: true | ||
| - name: Install packages | ||
| shell: bash | ||
| # yamllint disable rule:line-length |
There was a problem hiding this comment.
I wasn't able to make disable-line directive work with multiline string.
StrikerRUS
changed the title
StrikerRUS
requested review from
borchero,
guolinke,
jameslamb,
jmoralez and
shiyu1994
as code owners
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Thanks, this all looks good to me! I appreciate the comments you left on the diff explaining some of the workarounds .
| R_LIBS="c('R6', 'data.table', 'jsonlite', 'knitr', 'markdown', 'Matrix', 'RhpcBLASctl', 'testthat')" | ||
| RDscript${{ matrix.r_customization }} \ | ||
| -e "install.packages(${R_LIBS}, repos = 'https://cran.rstudio.com', Ncpus = parallel::detectCores())" |
There was a problem hiding this comment.
I'm ok with this for now now. But I think we should eventually just move all these R package installs into a single CI script like ci/install-r-deps.R, to reduce duplication. Would you support something like that? I can put up a PR if you agree.
There was a problem hiding this comment.
Absolutely, it would be great!
StrikerRUS
changed the title
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
2 participants
Last PR in series of PRs for linting yaml files.
This PR fixes long lines error.
Continuation of #6794.
See #6758 for background and future PRs' content required to fix all errors with the proposed config.
Closed #6758.