This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Implement BUILD_LIST_UNPACK #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests/test_emission.cpp
Outdated
| REQUIRE(!PyErr_Occurred()); | ||
|
|
||
| auto repr = PyUnicode_AsUTF8(PyObject_Repr(res)); | ||
| Py_DECREF(res); |
Contributor
There was a problem hiding this comment.
I think you need to constructor the std::string before doing the dec ref here, I think the lifetime of the PyUnicode_AsUTF8 is only guaranteed to be valid as long as the object is
Contributor
|
Otherwise LGTM |
Member
Author
|
I have fixed the refcount issues, but I have discovered that the |
Member
Author
|
Turns out the test failure is only when you run all tests; if you run the |
Member
Author
|
PTAL |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #106
If this is accepted then an issue should be opened up about leaking locals (which is only an issue in a OOM situation).