Skip to content

Update Stanford drivers to conform to docs standard#4436

Merged
bors[bot] merged 8 commits intomicrosoft:masterfrom
jenshnielsen:drivers/standford_cleanup
Aug 1, 2022
Merged

Update Stanford drivers to conform to docs standard#4436
bors[bot] merged 8 commits intomicrosoft:masterfrom
jenshnielsen:drivers/standford_cleanup

Conversation

@jenshnielsen
Copy link
Copy Markdown
Collaborator

I have left the drivers in the format SR860. I guess one could argue that they should be named SRSSR860 since SR is part of the model number but that feels too much.

@jenshnielsen jenshnielsen added the docs Related to docs improvements label Jul 29, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 29, 2022

Codecov Report

Merging #4436 (3c7f6d1) into master (3c7f6d1) will not change coverage.
The diff coverage is n/a.

❗ Current head 3c7f6d1 differs from pull request most recent head 7e52797. Consider uploading reports for the commit 7e52797 to get more accurate results

@@           Coverage Diff           @@
##           master    #4436   +/-   ##
=======================================
  Coverage   68.38%   68.38%           
=======================================
  Files         283      283           
  Lines       31043    31043           
=======================================
  Hits        21229    21229           
  Misses       9814     9814           

Copy link
Copy Markdown
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left the drivers in the format SR860. I guess one could argue that they should be named SRSSR860 since SR is part of the model number but that feels too much.

agree!

@jenshnielsen
Copy link
Copy Markdown
Collaborator Author

bors merge

@bors bors bot merged commit 74dc675 into microsoft:master Aug 1, 2022
@jenshnielsen jenshnielsen deleted the drivers/standford_cleanup branch August 1, 2022 08:51
@jenshnielsen jenshnielsen added this to the Public api rewrite milestone Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Related to docs improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants