Update lakeshore drivers to conform with standard#4473
Merged
jenshnielsen merged 10 commits intomicrosoft:masterfrom Aug 5, 2022
Merged
Update lakeshore drivers to conform with standard#4473jenshnielsen merged 10 commits intomicrosoft:masterfrom
jenshnielsen merged 10 commits intomicrosoft:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4473 +/- ##
==========================================
- Coverage 68.06% 67.99% -0.07%
==========================================
Files 292 295 +3
Lines 31320 31405 +85
==========================================
+ Hits 21317 21353 +36
- Misses 10003 10052 +49 |
astafan8
reviewed
Aug 4, 2022
Contributor
astafan8
left a comment
There was a problem hiding this comment.
I could be convinced that model should not be part of the class names. What do you think?
yeah... it's annoying, however it is part of the official name of the instrument, so if we want to follow our own convention, then we should. or we have to relax the conveniention in a clear way :)
I have copied the drivers rather than making the old ones aliases since there was a fair bit of renaming involved
sad, so much diplication :( and the tests then also need to be copied (or at least use the new drivers)
c1f094b to
3030f85
Compare
17581b4 to
0aa2752
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could be convinced that model should not be part of the class names. What do you think?
I have copied the drivers rather than making the old ones aliases since there was a fair bit of renaming involved but imported
the channel/modul classes from the new locations under aliases to avoid too much duplication.