Upgrade AMI drivers to conform to our standard

[jenshnielsen]

No description provided.

[codecov]

Codecov Report

Merging #4536 (f223109) into master (f25e4a6) will increase coverage by 0.02%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master    #4536      +/-   ##
==========================================
+ Coverage   68.05%   68.08%   +0.02%     
==========================================
  Files         299      299              
  Lines       31511    31535      +24     
==========================================
+ Hits        21446    21470      +24     
  Misses      10065    10065              

[jenshnielsen]

The issue seems to be caused by the AMI430.py file next to the visa fill. Need to debug why the stops sphinx looking for classes in the mro

[jenshnielsen]

Thinking a bit more about this. Its not strange that this trips up. Both the old Module and the class are called AMI430 so sphinx ends up trying to import the old AMI430 module rather than the class. This also has a AMI430 class but which inherits from ipinstrument so its lacking the expected attributes.

Not sure what the best is.

1. Rename the old module to AMI_430.py perhaps. This would be the cleanest but is also a breaking change.
2. Rename the class as exported to something else. Can be done without breaking changes but is less ideal

Edit Decided to change the name of the public class at the top level to avoid this and reflect that the instrument is called AMI Model 430

@astafan8 would be great if you can have a look

[jenshnielsen]

bors merge

[bors]

Build succeeded:

• builddocs (ubuntu-latest, 3.10)
• builddocs (ubuntu-latest, 3.9)
• builddocs (windows-latest, 3.7)
• pytestmin (ubuntu-latest, 3.7)
• pytestmypy (ubuntu-latest, 3.10)
• pytestmypy (ubuntu-latest, 3.7)
• pytestmypy (ubuntu-latest, 3.8)
• pytestmypy (ubuntu-latest, 3.9)
• pytestmypy (windows-latest, 3.10)
• pytestnonlocal (3.7)