Add a callback to get_parameter_data to follow data loading#4688
Merged
jenshnielsen merged 25 commits intomicrosoft:masterfrom Nov 28, 2022
Merged
Add a callback to get_parameter_data to follow data loading#4688jenshnielsen merged 25 commits intomicrosoft:masterfrom
jenshnielsen merged 25 commits intomicrosoft:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
In the effort to use qcodes as the data loader of the pyplotter I added a callback to
get_parameter. This is usefull to track the progress of the data download.Since sqlite3 does not allow to keep track of the data loading progress, we compute how many sqlite requests correspond to a certain percentage of progress which is dictated by a config parameter. Then we perform
xsql request instead of one, running the callback everytime.The whole process add an overhead of ~13% on my laptop when used which is not negligible.
However, I would argue that keeping track of the download progress for a GUI is precious and is worth the overhead.
To test the download time
I kept the change minimal hoping other people will have comments.