Load coordinates from netcdf in the correct order.#4802
Merged
bors[bot] merged 3 commits intomicrosoft:masterfrom Nov 15, 2022
Merged
Load coordinates from netcdf in the correct order.#4802bors[bot] merged 3 commits intomicrosoft:masterfrom
bors[bot] merged 3 commits intomicrosoft:masterfrom
Conversation
data_array.coords is not guaranteed to return in the same order as its written. However, this is guaranteed for data_array.dims so use that to order coords when loading
jenshnielsen
force-pushed
the
fix_netcdf_loading_order
branch
from
bd44785 to
ad2af85
Compare
Codecov Report
@@ Coverage Diff @@
## master #4802 +/- ##
==========================================
- Coverage 68.28% 68.25% -0.03%
==========================================
Files 339 339
Lines 32070 32070
==========================================
- Hits 21899 21890 -9
- Misses 10171 10180 +9 |
guenp
approved these changes
Nov 14, 2022
guenp
left a comment
guenp
left a comment
There was a problem hiding this comment.
Tested and this fixes my problem. Thank you @jenshnielsen!
astafan8
approved these changes
Nov 15, 2022
Contributor
astafan8
left a comment
astafan8
left a comment
There was a problem hiding this comment.
great! (the only comment can be ignored)
jenshnielsen
force-pushed
the
fix_netcdf_loading_order
branch
from
553c109 to
8222f1f
Compare
Collaborator
Author
|
bors merge |
Contributor
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data_array.coords is not guaranteed to return
in the same order as its written. However, this is guaranteed for data_array.dims so use that to order coords when loading
TODO