Skip to content

Oxford Triton: Add control of pumps and temperature channels#5316

Merged
jenshnielsen merged 19 commits intomicrosoft:masterfrom
FredWolff:add_control_of_pumps_and_temperature_channels
Aug 24, 2023
Merged

Oxford Triton: Add control of pumps and temperature channels#5316
jenshnielsen merged 19 commits intomicrosoft:masterfrom
FredWolff:add_control_of_pumps_and_temperature_channels

Conversation

@FredWolff
Copy link
Copy Markdown
Contributor

@FredWolff FredWolff commented Aug 14, 2023

This pull request adds the following parameters to the driver: pid_p, pid_i, pid_d, turb1_speed, turb1_state, comp_state and Tx_state where x represents the temperature channel id and runs from 1 to 17. The pid-parameters set and get the pid-values for the temperature controller. turb1_speed gets the speed of the turbo in Hz. The _state parameters get and set whether the pumps and temperature channels are on or off.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 14, 2023

Codecov Report

Merging #5316 (1723b01) into master (5c1fd24) will decrease coverage by 0.04%.
Report is 33 commits behind head on master.
The diff coverage is 5.98%.

@@            Coverage Diff             @@
##           master    #5316      +/-   ##
==========================================
- Coverage   67.63%   67.59%   -0.04%     
==========================================
  Files         360      360              
  Lines       29987    30012      +25     
==========================================
+ Hits        20283    20288       +5     
- Misses       9704     9724      +20     

@FredWolff FredWolff marked this pull request as ready for review August 14, 2023 14:49
@jenshnielsen jenshnielsen changed the title Add control of pumps and temperature channels Oxford Triton: Add control of pumps and temperature channels Aug 23, 2023
@jenshnielsen jenshnielsen enabled auto-merge August 24, 2023 08:38
@jenshnielsen jenshnielsen added this pull request to the merge queue Aug 24, 2023
Merged via the queue into microsoft:master with commit 761f244 Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants