Calculate new run_id/counter from run_id/counter#5329
Merged
jenshnielsen merged 3 commits intomicrosoft:masterfrom Aug 24, 2023
Merged
Calculate new run_id/counter from run_id/counter#5329jenshnielsen merged 3 commits intomicrosoft:masterfrom
jenshnielsen merged 3 commits intomicrosoft:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5329 +/- ##
==========================================
- Coverage 67.59% 67.56% -0.04%
==========================================
Files 360 360
Lines 30012 30021 +9
==========================================
- Hits 20288 20284 -4
- Misses 9724 9737 +13 |
astafan8
approved these changes
Aug 24, 2023
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #5328 by ensuring that new runs are inserted with a captured counter/runid that matches the assigned run_id / counter