Add note about deprecated methods to docstrings#6657
Merged
jenshnielsen merged 2 commits intomicrosoft:mainfrom Nov 29, 2024
Merged
Add note about deprecated methods to docstrings#6657jenshnielsen merged 2 commits intomicrosoft:mainfrom
jenshnielsen merged 2 commits intomicrosoft:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6657 +/- ##
=======================================
Coverage 69.38% 69.38%
=======================================
Files 340 340
Lines 31336 31336
=======================================
Hits 21743 21743
Misses 9593 9593 ☔ View full report in Codecov by Sentry. |
3 tasks
jenshnielsen
force-pushed
the
jenshnielsen/mark_deprecated
branch
from
996e433 to
1c1e1de
Compare
einsmein
reviewed
Nov 25, 2024
einsmein
requested changes
Nov 25, 2024
Contributor
einsmein
left a comment
einsmein
left a comment
There was a problem hiding this comment.
One minor comment and LGTM
jenshnielsen
force-pushed
the
jenshnielsen/mark_deprecated
branch
from
1c1e1de to
593ab3f
Compare
Collaborator
Author
|
@einsmein Fixed, ready for another review. |
einsmein
approved these changes
Nov 29, 2024
jenshnielsen
force-pushed
the
jenshnielsen/mark_deprecated
branch
from
593ab3f to
b8c17d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #6648 this really should be documented.