Allow extra on log messages via InstrumentLogger#7186
Merged
jenshnielsen merged 3 commits intomicrosoft:mainfrom Jun 2, 2025
Merged
Allow extra on log messages via InstrumentLogger#7186jenshnielsen merged 3 commits intomicrosoft:mainfrom
jenshnielsen merged 3 commits intomicrosoft:mainfrom
Conversation
0440f02 to
1346920
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7186 +/- ##
=======================================
Coverage 59.92% 59.92%
=======================================
Files 342 342
Lines 31472 31481 +9
=======================================
+ Hits 18859 18865 +6
- Misses 12613 12616 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This allows the user to add extra information to the messages logged via the InstrumentLoggerAdapter.
astafan8
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstrumentLoggerAdapterby default discards any information that is added to the LogRecord via extra. This extends the new 3.13 feature to allow the user to add extra information to the messages logged via theInstrumentLoggerAdapterregardless of the version of python.