Skip to content

Make InstrumentModule/Channel take a generic instrument argument#7659

Merged
jenshnielsen merged 4 commits intomicrosoft:mainfrom
jenshnielsen:generic_parent
Nov 19, 2025
Merged

Make InstrumentModule/Channel take a generic instrument argument#7659
jenshnielsen merged 4 commits intomicrosoft:mainfrom
jenshnielsen:generic_parent

Conversation

@jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Nov 19, 2025

This makes it possible to write drivers that use features from the parent without explicit cast

  • Changelog

@jenshnielsen jenshnielsen requested a review from a team as a code owner November 19, 2025 05:52
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 40.74074% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.77%. Comparing base (6482ff0) to head (3c9010c).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...rc/qcodes/instrument_drivers/rigol/Rigol_DG1062.py 35.71% 9 Missing ⚠️
src/qcodes/instrument/channel.py 0.00% 6 Missing ⚠️
...nstrument_drivers/Lakeshore/Lakeshore_model_325.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7659      +/-   ##
==========================================
+ Coverage   59.66%   59.77%   +0.11%     
==========================================
  Files         352      352              
  Lines       31656    31655       -1     
==========================================
+ Hits        18888    18923      +35     
+ Misses      12768    12732      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jenshnielsen jenshnielsen added this pull request to the merge queue Nov 19, 2025
Merged via the queue into microsoft:main with commit 8817ba7 Nov 19, 2025
17 of 18 checks passed
@jenshnielsen jenshnielsen deleted the generic_parent branch November 19, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants