Merged
Conversation
- add size check - refactor some codes
|
|
Contributor
|
Sorry for leaving this hanging for a while. The quality of this PR is very good. There are extra works needed from our side to complete BGV, such as an example, instruction on modulus switching, and a noise estimator. We currently are too occupied to roll out a major release. We want to accept the PR as soon as we can work on version 3.7. Please be patient with us. Much appreciated! |
Contributor
|
Thank you for this incredible contribution. I've merged this PR to internal SEAL. There are some changes planned on our side. Eventually it will appear in the next major release. |
Rcontre360
pushed a commit
to Rcontre360/SEAL
that referenced
this pull request
Apr 17, 2025
* add sum_vector for BFVVector * add python tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of BGV in SEAL (i.e., git@github.com:Alibaba-Gemini-Lab/Gemini-SEAL-BGV.git), which has been merged with the latest contrib branch.