add const qualifier to Evaluator and BatchEncoder functions#334
Merged
WeiDaiWD merged 1 commit intomicrosoft:contribfrom May 11, 2021
Merged
add const qualifier to Evaluator and BatchEncoder functions#334WeiDaiWD merged 1 commit intomicrosoft:contribfrom
WeiDaiWD merged 1 commit intomicrosoft:contribfrom
Conversation
|
|
Contributor
|
Thanks for catching them, Alex! We might have missed these methods when we changed their definitions previously. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #333
This adds const qualifiers to functions like
BatchEncoder::encodeorEvaluator::addthat modify their operands but not the actual Encoder/Evaluator object.This helps quite a bit with writing "neat" code against SEAL (less for individual applications, more for frameworks and compilers)