Skip to content

half guess count in util::try_minimal_primitive_root#430

Merged
WeiDaiWD merged 1 commit intomicrosoft:mainfrom
zirconium-n:generator_step_2
Mar 15, 2022
Merged

half guess count in util::try_minimal_primitive_root#430
WeiDaiWD merged 1 commit intomicrosoft:mainfrom
zirconium-n:generator_step_2

Conversation

@zirconium-n
Copy link
Contributor

Since we are multiplying generator_sq each guess, we should increment i by 2 instead of 1.

@WeiDaiWD WeiDaiWD merged commit 4c1b90b into microsoft:main Mar 15, 2022
@WeiDaiWD
Copy link
Contributor

It makes perfect sense. Thanks for your contribution!

@WeiDaiWD
Copy link
Contributor

This PR should be made to the contrib branch. I'm going to make the commit myself but leave your GitHub info and PR number in the commit message.

WeiDaiWD pushed a commit that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants