module.exports aliases have correct flags #28303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are marked both as (1) alias and (2) assignment declaration. This
fixes alias resolution in cases where multiple module.exports
assignments exist, but differ in whether they are aliases or not:
```js
function f() { }
module.exports = f
module.exports = 23
```
Previously, this construct would fail to resolve the alias `f` because
the `export=` symbol would be marked as Alias | Value but not
Assignment. This change just adds Assignment so that the assignment
declaration alias-following rules apply: you should always follow the
alias, regardless of other flags.
Also, isAliasSymbolDeclaration needed to be tightened up. Previously, I
missed the condition that `module.exports =` aliases required an
EntityNameDeclaration on right-hand-side, just like `export default` and
`export =` aliases.
ghost
reviewed
Nov 2, 2018
src/compiler/binder.ts
Outdated
| // 'module.exports = expr' assignment | ||
| const flags = exportAssignmentIsAlias(node) | ||
| ? SymbolFlags.Alias // An export= with an EntityNameExpression or a ClassExpression exports all meanings of that identifier or class | ||
| ? SymbolFlags.Alias | SymbolFlags.Assignment // An export= with an EntityNameExpression or a ClassExpression exports all meanings of that identifier or class |
There was a problem hiding this comment.
So why is it not flagged as Assignment in the other case?
Member
Author
There was a problem hiding this comment.
No good reason! The other uses of Assignment are unconditional now as well. Nice catch.
1. Rename test to be more accurate. 2. Always mark module.exports assignments with SymbolFlags.Assignment.
ghost
approved these changes
Nov 2, 2018
sheetalkamat
approved these changes
Nov 2, 2018
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are marked both as (1) alias and (2) assignment declaration. This fixes alias resolution in cases where multiple module.exports assignments exist, but differ in whether they are aliases or not:
Previously, this construct would fail to resolve the alias
fbecause theexport=symbol would be marked as Alias | Value but not Assignment. This change just adds Assignment so that the assignment declaration alias-following rules apply: you should always follow the alias, regardless of other flags.Also, isAliasSymbolDeclaration needed to be tightened up. Previously, I missed the condition that
module.exports =aliases required an EntityNameDeclaration on right-hand-side, just likeexport defaultandexport =aliases.Fixes #27857