Conversation
Member
Author
|
OK. The other baseline changes are as expected due to the rather non-obvious behavior described in the comment at https://github.com/Microsoft/TypeScript/blob/master/src/harness/compilerRunner.ts#L95 . So this should be good to go. |
Merged
| }); | ||
| // There may be multiple files with different baselines. Run all and report at the end, else | ||
| // it stops copying the remaining emitted files from 'local/projectOutput' to 'local/project'. | ||
| try { |
Contributor
There was a problem hiding this comment.
sorry about that. i had this fixed a while back in the transforms branch, but never ported it back.
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9542 . It took me about an hour to fix the issue, and another 4 to figure out why the baselines were dropping files for the test changes 😩 (see comment on changes in
projectsRunner.ts).I'm still verifying the changes to a couple of existing baselines are correct, but wanted to get this out for review now.