Add container ID to WSLA_CONTAINER so the CLI doesn't require a WslaContainer reference during simple wslc container list#14243
Open
OneBlue wants to merge 3 commits intofeature/wsl-for-appsfrom
Open
Conversation
…ontainer reference during simple wslc container list
dkbennett
approved these changes
Feb 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the WSLA container listing data contract to include the container ID, allowing wslc to list containers (including unnamed ones) without opening/inspecting each container.
Changes:
- Adds
Idto theWSLA_CONTAINERstruct returned byIWSLASession::ListContainers. - Populates
WSLA_CONTAINER::IdinWSLASession::ListContainers. - Updates
wslc’sContainerService::List()to use the returnedIddirectly and updates tests to validateIdis present.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/windows/WSLATests.cpp | Adds an assertion that returned WSLA_CONTAINER entries include a full-length ID. |
| src/windows/wslc/services/ContainerService.cpp | Switches container listing to use WSLA_CONTAINER::Id instead of opening/inspecting containers. |
| src/windows/wslasession/WSLASession.cpp | Fills the new Id field when constructing the WSLA_CONTAINER array. |
| src/windows/wslaservice/inc/wslaservice.idl | Adds Id to WSLA_CONTAINER and relocates the WSLAContainerId typedef near container types. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
AmelBawa-msft
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change adds ID to the list of returned fields when listing a container, which fixes list for containers without names and allows a simpler implementation of the simple case for List()
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed