Fix UtilExec: remove premature Result check that breaks output capture#40327
Merged
benhillis merged 1 commit intofeature/wsl-for-appsfrom Apr 27, 2026
Merged
Conversation
Result was initialized to -1 and checked (Result < 0) inside the fgets loop before ever being set to a success value. This caused the first iteration to immediately goto ErrorExit, making all output capture dead code. The Result variable is properly set after the loop completes via pclose(), so the in-loop check was erroneous. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression in UtilExecCommandLine() where an in-loop Result < 0 check caused an early goto ErrorExit, making normal output capture effectively unreachable (since Result is initialized to -1 and only set after the read loop).
Changes:
- Remove the erroneous
Result < 0/goto ErrorExitblock inside thefgets()loop so output can be accumulated as intended.
JohnMcPMS
approved these changes
Apr 27, 2026
OneBlue
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the feature branch, an
if (Result < 0) { goto ErrorExit; }check was added inside the fgets loop in UtilExec. Since Result is initialized to -1 and not set until after the loop (via pclose()), this fires on the first iteration, making output capture dead code.This bug does not exist on master — it was introduced on the feature branch.
Fix: Remove the erroneous 4-line check.