Remove unreachable else branch in TTY stdin relay#40330
Open
benhillis wants to merge 1 commit intofeature/wsl-for-appsfrom
Open
Remove unreachable else branch in TTY stdin relay#40330benhillis wants to merge 1 commit intofeature/wsl-for-appsfrom
benhillis wants to merge 1 commit intofeature/wsl-for-appsfrom
Conversation
write() on success returns a value in [0, count]. The condition (bytesWritten <= pendingStdin.size()) is therefore always true, making the else branch dead code. Simplify to unconditional erase. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the Linux-side TTY stdin relay in WSLCInit.cpp by removing an unreachable else branch after a successful write() call, based on POSIX write() semantics (success returns 0..count).
Changes:
- Remove dead-code branch that logged an “Unexpected write result” after a successful
write(). - Unconditionally erase the written prefix of
pendingStdinon successfulwrite().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write() on success returns a value in [0, count]. The condition (bytesWritten <= pendingStdin.size()) is therefore always true, making the else branch dead code. Simplify to unconditional erase.