Remove duplicate object inclusion for wslc executable#40331
Merged
benhillis merged 1 commit intofeature/wsl-for-appsfrom Apr 27, 2026
Merged
Remove duplicate object inclusion for wslc executable#40331benhillis merged 1 commit intofeature/wsl-for-appsfrom
benhillis merged 1 commit intofeature/wsl-for-appsfrom
Conversation
wslclib is an OBJECT library. Both \$<TARGET_OBJECTS:wslclib> in add_executable() and target_link_libraries(wslc wslclib) include the same object files. In CMake 3.12+, linking an OBJECT library brings both objects and transitive dependencies, making the generator expression redundant and potentially causing duplicate symbol issues. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies how wslc.exe is built by removing redundant inclusion of wslclib object files, relying on modern CMake behavior where linking an OBJECT library contributes its objects and usage requirements.
Changes:
- Remove
$<TARGET_OBJECTS:wslclib>fromadd_executable(wslc ...). - Add a clarifying comment explaining why the generator expression should not be used alongside linking the object library.
yao-msft
approved these changes
Apr 27, 2026
JohnMcPMS
approved these changes
Apr 27, 2026
OneBlue
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wslclib is an OBJECT library. Both the TARGET_OBJECTS generator expression in add_executable() and target_link_libraries(wslc wslclib) include the same object files. In CMake 3.12+, linking an OBJECT library brings both objects and transitive dependencies, making the generator expression redundant. Remove it to avoid potential duplicate symbol issues.