-
Notifications
You must be signed in to change notification settings - Fork 434
Add license support to Deployment API and a new InstallLicenses API #1790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4236a4c
Updated DeploymentManager to install license files if necessary
DrusTheAxe 6252aa2
Add stubs for the InstallLicenseFile() methods
DrusTheAxe f3ce39f
Change installer to install licenses BEFORE packages, for higher reli…
DrusTheAxe 0c7fd27
Copy the license header to the source tree to use whehn building via …
DrusTheAxe cfd59e2
Add Licensing API and export from Bootstrap'r
DrusTheAxe 0a17d2c
Added some pseudocode in MsixInstallLicenses(). Real implementation c…
DrusTheAxe a722456
yml changes to pickup licensing package when needed.
f29e76c
moving restore to the top of the pipeline.
caf20e6
moving back, wrong stage
40ea758
Fixed license filename
DrusTheAxe b172179
Merge branch 'user/drustheaxe/license-apis' of https://github.com/mic…
DrusTheAxe 8d96a12
add nuget authenticate call
154ab71
Merge branch 'user/drustheaxe/license-apis' of https://github.com/mic…
DrusTheAxe b067ee0
differnt connection
4b816be
adding nuget config for build
3b2734b
avoid using licensing support in github / PR builds, which don't have…
8ba34b8
update script to capture package version / name.
a8d12bc
one missed check
7ed10f7
Incorported feedback
DrusTheAxe 973423d
udpdating nuget.config name to avoid conflicts.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <configuration> | ||
| <config> | ||
| <!-- | ||
| Where packages should go. Visual Studio will provide a default value of $(SolutionDir) but command-line based | ||
| package restores could end up in a different location. Setting this value keeps Visual Studio and NuGet.exe | ||
| in sync for packages.config based restores. | ||
| --> | ||
| <add key="repositoryPath" value=".\packages" /> | ||
| </config> | ||
| <packageRestore> | ||
| <add key="enabled" value="True" /> | ||
| <add key="automatic" value="True" /> | ||
| </packageRestore> | ||
| <activePackageSource> | ||
| <add key="All" value="(Aggregate source)" /> | ||
| </activePackageSource> | ||
| <packageSources> | ||
| <clear /> | ||
| <add key="Project.Reunion.nuget.internal" value="https://pkgs.dev.azure.com/microsoft/ProjectReunion/_packaging/Project.Reunion.nuget.internal/nuget/v3/index.json" /> | ||
| </packageSources> | ||
| <disabledPackageSources> | ||
| <clear /> | ||
| </disabledPackageSources> | ||
| </configuration> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| Param( | ||
| [Parameter(Position=0)] | ||
| [string]$versionDetailsPath = "", | ||
| [Parameter(Position=1)] | ||
| [string]$packageConfigPath = "" | ||
| ) | ||
|
|
||
| [xml]$buildConfig = Get-Content -Path $versionDetailsPath | ||
|
|
||
| $packagesText = | ||
| @" | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <packages> | ||
| <!-- Transport packages from the feeder repositories --> | ||
|
|
||
| "@ | ||
| foreach ($dependency in $buildConfig.Dependencies.ProductDependencies.Dependency) | ||
| { | ||
| $name = $dependency.name | ||
| $ver = $dependency.version | ||
| Write-Host "id: " $name | ||
| Write-Host "ver: " $ver | ||
|
|
||
| if ($name -eq "Microsoft.WindowsAppSDK.AppLicensingInternal.TransportPackage") | ||
| { | ||
| Write-Host "##vso[task.setvariable variable=AppLicensingInternalPackageName;]$name" | ||
| Write-Host "##vso[task.setvariable variable=AppLicensingInternalPackageVersion;]$ver" | ||
| } | ||
|
|
||
| $packagesText += ' <package id="' + $name + '" version="' + $ver + '" targetFramework="native" /> | ||
| ' | ||
| } | ||
| $packagesText += | ||
| @" | ||
| </packages> | ||
| "@ | ||
|
|
||
| Write-Host $packagesText | ||
|
|
||
| Set-Content -Value $packagesText $packageConfigPath |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup Label="Globals"> | ||
| <MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects> | ||
| <HasSharedItems>true</HasSharedItems> | ||
| <ItemsProjectGuid>{885A43FA-052D-4b0d-A2DC-13EE15796435}</ItemsProjectGuid> | ||
| <ItemsProjectName>Licensing</ItemsProjectName> | ||
| </PropertyGroup> | ||
| <ItemDefinitionGroup> | ||
| <ClCompile> | ||
| <AdditionalIncludeDirectories>%(AdditionalIncludeDirectories);$(MSBuildThisFileDirectory)</AdditionalIncludeDirectories> | ||
| </ClCompile> | ||
| </ItemDefinitionGroup> | ||
| <ItemGroup> | ||
| <ProjectCapability Include="SourceItemsFromImports" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ClInclude Include="$(MSBuildThisFileDirectory)WindowsAppRuntime-License.h" /> | ||
| <ClInclude Include="$(MSBuildThisFileDirectory)MsixLicensing.h" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ClCompile Include="$(MSBuildThisFileDirectory)MsixLicensing.cpp" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <PublicHeaders Include="$(MSBuildThisFileDirectory)MsixLicensing.h" /> | ||
| </ItemGroup> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
|
|
||
| #include "pch.h" | ||
|
|
||
| #include "msixlicensing.h" | ||
|
|
||
| #include <WindowsAppRuntime-License.h> | ||
|
|
||
| STDAPI MsixInstallLicenses() noexcept try | ||
| { | ||
| //TODO | ||
| // FOREACH file IN pkgdir\MSIX\*_license.xml | ||
| // InstallLicenseFile(file) | ||
| return S_OK; | ||
| } | ||
| CATCH_RETURN(); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
|
|
||
| #ifndef __MSIXLICENSING_H | ||
| #define __MSIXLICENSING_H | ||
|
|
||
| STDAPI MsixInstallLicenses() noexcept; | ||
|
|
||
| #endif // __MSIXLICENSING_H |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.