FI main into WNP_ToastNotifications#1964
FI main into WNP_ToastNotifications#1964loneursid merged 1 commit intofeature/WNP_ToastNotificationsfrom
Conversation
…on/_git/ProjectReunionInternal build Maestro-UpdateEngCommon_2201.10001 (#1962) Microsoft.WinAppSDK.EngCommon From Version 1.0.0-20211213.0-CI -> To Version 1.0.0-20220110.0-CI Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
ghost
added
the
loneursid
changed the title
| <Uri>https://github.com/microsoft/CsWinRT</Uri> | ||
| <Sha></Sha> | ||
| <Sha> | ||
| </Sha> |
There was a problem hiding this comment.
Why separate lines when 1 line is used when there's a value e.g. line 28
| filePath: 'TestAll.ps1' | ||
| arguments: > | ||
| -WindowsAppSDKPackageVersion "$(WindowsAppSDKPackageVersion)" | ||
| -Checkpoint "none" -Platform "x64" |
There was a problem hiding this comment.
Since you seem to be doing 1 arg per line move -Platform to its own line
|
@loneursid I submitted a review with comments and hit the Approve radio button, as it was an "Approved with comments". I didn't notice Auto-Complete was enabled, and GitHub will complete a PR even if those open/unresolved/active comments :-( Please make a new follow up PR addressing my comments. Thanks |
|
@DrusTheAxe - This is a forward integration of main into a feature branch. Your comments are valid but this PR (and feature branch) isn't the place to address them. We want this feature branch to on par with main, excepted for changes related to notifications. I only ever set "auto-complete" for PRs that are FI without conflicts, like this one. |
2 participants
FI main - no conflicts