RS5 Fixes#2060
Merged
pmpurifoy merged 28 commits intofeature/WNP_ToastNotifications_L1from Feb 14, 2022
Merged
Conversation
Contributor
pmpurifoy
commented
Feb 2, 2022
pmpurifoy
commented
- Includes fixes to ChannelRequest for packaged applications in RS5
- Move from ShellExecuteEx to ComActivation for packaged applications in RS5 in background activation
ghost
added
the
* Adding temp idl for base branch * Create .cpp/.h files for handling toastnotifications * Introduce ToastNotification Registration APIs (#1875) * Introduce ToastRegistration APIs and associated taef tests * Address comments * Address minor comments * Add support for Release x64 for ToastNotificationTestApp * Addressing nits * Add GetActivatorGuid function * Last nits * Update error messages Co-authored-by: Paul Purifoy <purifoypaul@microsoft.com> * Forward integrate main into WNP_ToastNotifications (#1970) * Added header so MddBootstrapAutoInitializer.cpp compiles regardless of precompiled headers (#1947) * Update dependencies from https://dev.azure.com/microsoft/ProjectReunion/_git/ProjectReunionInternal build Maestro-UpdateEngCommon_2201.10001 (#1962) Microsoft.WinAppSDK.EngCommon From Version 1.0.0-20211213.0-CI -> To Version 1.0.0-20220110.0-CI Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Run the Foundation test suite from the Internal Integraiton tests (#1963) Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: reunion-maestro[bot] <81196566+reunion-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Revert "Forward integrate main into WNP_ToastNotifications (#1970)" This reverts commit a981a1e. Co-authored-by: Paul Purifoy <purifoypaul@microsoft.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: reunion-maestro[bot] <81196566+reunion-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com>
* Adding temp idl for base branch * Create .cpp/.h files for handling toastnotifications * Introduce ToastNotification Registration APIs (#1875) * Introduce ToastRegistration APIs and associated taef tests * Address comments * Address minor comments * Add support for Release x64 for ToastNotificationTestApp * Addressing nits * Add GetActivatorGuid function * Last nits * Update error messages Co-authored-by: Paul Purifoy <purifoypaul@microsoft.com> * Forward integrate main into WNP_ToastNotifications (#1970) * Added header so MddBootstrapAutoInitializer.cpp compiles regardless of precompiled headers (#1947) * Update dependencies from https://dev.azure.com/microsoft/ProjectReunion/_git/ProjectReunionInternal build Maestro-UpdateEngCommon_2201.10001 (#1962) Microsoft.WinAppSDK.EngCommon From Version 1.0.0-20211213.0-CI -> To Version 1.0.0-20220110.0-CI Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Run the Foundation test suite from the Internal Integraiton tests (#1963) Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: reunion-maestro[bot] <81196566+reunion-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Fixing build files for ToastNotificationTestApp/ToastNotificationTests * File was renamed to main Co-authored-by: Paul Purifoy <purifoypaul@microsoft.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: reunion-maestro[bot] <81196566+reunion-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com>
* Add ToastNotificationManger::Setting API * Addressing nits * Update ToastNotificationManager.cpp
* Adding temp idl for base branch * Create .cpp/.h files for handling toastnotifications * Introduce ToastNotification Registration APIs (#1875) * Introduce ToastRegistration APIs and associated taef tests * Address comments * Address minor comments * Add support for Release x64 for ToastNotificationTestApp * Addressing nits * Add GetActivatorGuid function * Last nits * Update error messages Co-authored-by: Paul Purifoy <purifoypaul@microsoft.com> * Copy branch based on WNP_ToastNotifications * Address nit * Addressing nits * Address nits * Change name from ToastActivation->AppNotification * Change more constants * Reuse deserialize function Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com>
Implemented ToastNotification + unit tests
…1976) * Adding temp idl for base branch * Create .cpp/.h files for handling toastnotifications * Introduce ToastNotification Registration APIs (#1875) * Introduce ToastRegistration APIs and associated taef tests * Address comments * Address minor comments * Add support for Release x64 for ToastNotificationTestApp * Addressing nits * Add GetActivatorGuid function * Last nits * Update error messages Co-authored-by: Paul Purifoy <purifoypaul@microsoft.com> * Rebase to WPN_ToastNotifications * Update externs.h * Rename toastGuid->appId * Addressing nits * Add sink check to AddToastRegistrationMapping * Adding lock to HasSinkForAppId * Change lock to shared lock * Add unit tests, rename appId->toastAppId * Add BuildAppIdentifier * Remove HasSinkForAppId * Move toastStorage to ToastNotificationManager * Address nits * Update platform.cpp * Adding packaged apps treated as unpackaged scenario * Flip the bool * Update platform.cpp * Fix remaining nits * last nits Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com>
* Initial Commit * Working packaged background RS5 * Remove IRawSerializer * Update NotificationListener.cpp
pmpurifoy
force-pushed
the
user/purifoypaul/RS5Fixes
branch
from
27ca1f6 to
a376427
Compare
pmpurifoy
requested review from
David-Quero,
danielayala94,
hulumane,
loneursid and
sharath2727
loneursid
added
the
area-Notifications
hulumane
reviewed
Feb 3, 2022
hulumane
reviewed
Feb 3, 2022
hulumane
reviewed
Feb 3, 2022
hulumane
reviewed
Feb 3, 2022
hulumane
reviewed
Feb 3, 2022
hulumane
reviewed
Feb 3, 2022
hulumane
reviewed
Feb 3, 2022
hulumane
reviewed
Feb 3, 2022
hulumane
reviewed
Feb 3, 2022
hulumane
reviewed
Feb 3, 2022
hulumane
reviewed
Feb 8, 2022
hulumane
reviewed
Feb 8, 2022
danielayala94
approved these changes
Feb 10, 2022
Contributor
danielayala94
left a comment
danielayala94
left a comment
There was a problem hiding this comment.
I see the ToastNotificationDemoApp is coming with this PR. Are you planning to check it in here or from the DemoApp PR?
Also, be careful with the renaming work before merging.
Contributor
Author
I'm checking in the DemoApp PR first, then this PR. |
hulumane
reviewed
Feb 11, 2022
hulumane
reviewed
Feb 11, 2022
hulumane
reviewed
Feb 11, 2022
hulumane
reviewed
Feb 11, 2022
hulumane
reviewed
Feb 11, 2022
hulumane
approved these changes
Feb 11, 2022
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.