Rename all instances of Toast in Public API layer to AppNotifications#2063
Merged
hulumane merged 4 commits intofeature/WNP_ToastNotifications_L1from Feb 10, 2022
Merged
Conversation
ghost
added
the
hulumane
force-pushed
the
user/pavanh/rename-APIs
branch
2 times, most recently
from
384a2ea to
e332efa
Compare
loneursid
added
the
area-Notifications
loneursid
reviewed
Feb 5, 2022
Contributor
|
I'm getting a compile error in: test/TestApps/PushNotificationsDemoApp/pch.h. Can't find: winrt/Microsoft.Windows.ToastNotifications.h |
hulumane
force-pushed
the
user/pavanh/rename-APIs
branch
2 times, most recently
from
3be3a79 to
ff9242f
Compare
hulumane
force-pushed
the
user/pavanh/rename-APIs
branch
from
2b8713b to
e5a95df
Compare
sharath2727
reviewed
Feb 10, 2022
Contributor
|
/azp run |
pmpurifoy
approved these changes
Feb 10, 2022
|
Azure Pipelines successfully started running 1 pipeline(s). |
loneursid
approved these changes
Feb 10, 2022
Contributor
loneursid
left a comment
loneursid
left a comment
There was a problem hiding this comment.
Re-ran all the tests for push and toast. Got a few failures for push on the first run but everything was green on the second one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have received developer feedback that we need to infer Toasts as simply Notifications. This PR renames the Public API surface to reflect that change. More changes are incoming as this goes through the API review process.