Skip to content

Move CSWinRT to Toolset Dependencies in Version.Details.xml #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kythant merged 2 commits into from
Feb 9, 2022
Merged

Move CSWinRT to Toolset Dependencies in Version.Details.xml #2084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56c5769
Move cswinrt to toolset
kythant Feb 9, 2022
78e9e45
fix typo:
kythant Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions build/scripts/ConvertVersionDetailsToPackageConfig.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,9 @@ foreach ($dependency in $buildConfig.Dependencies.ProductDependencies.Dependency
Write-Host "##vso[task.setvariable variable=AppLicensingInternalPackageVersion;]$ver"
}

$excluded = $name.StartsWith("CsWinRT.Dependency.")
if (-not $excluded)
{
$packagesText += ' <package id="' + $name + '" version="' + $ver + '" targetFramework="native" />
$packagesText += ' <package id="' + $name + '" version="' + $ver + '" targetFramework="native" />
'
}

}
$packagesText +=
@"
Expand Down
14 changes: 7 additions & 7 deletions eng/Version.Details.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
<?xml version="1.0" encoding="utf-8"?>
<Dependencies>
<ProductDependencies>
<Dependency Name="Microsoft.WindowsAppSDK.AppLicensingInternal.TransportPackage" Version="1.0.0-preview1.20211111.12">
<Uri>https://dev.azure.com/microsoft/ProjectReunion/_git/ProjectReunionClosed</Uri>
<Sha>a3b6cd2d041c342d4a5ac2ed0c90c30e9ed08f15</Sha>
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.Windows.CsWinRT" Version="1.5.0-prerelease.220124.4">
<Uri>https://github.com/microsoft/CsWinRT</Uri>
<Sha>c90d2e33c650b65377a3eb046f1f449d56e2ab7d</Sha>
Comment thread
kythant marked this conversation as resolved.
</Dependency>
<Dependency Name="CsWinRT.Dependency.DotNetCoreSdkn" Version="5.0.404">
<Dependency Name="CsWinRT.Dependency.DotNetCoreSdk" Version="5.0.404">
<Uri>https://github.com/microsoft/CsWinRT</Uri>
<Sha>
</Sha>
Expand All @@ -18,12 +24,6 @@
<Uri>https://github.com/microsoft/CsWinRT</Uri>
<Sha>c90d2e33c650b65377a3eb046f1f449d56e2ab7d</Sha>
</Dependency>
<Dependency Name="Microsoft.WindowsAppSDK.AppLicensingInternal.TransportPackage" Version="1.0.0-preview1.20211111.12">
<Uri>https://dev.azure.com/microsoft/ProjectReunion/_git/ProjectReunionClosed</Uri>
<Sha>a3b6cd2d041c342d4a5ac2ed0c90c30e9ed08f15</Sha>
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.WinAppSDK.EngCommon" Version="1.1.0-20220125.0-CI">
<Uri>https://dev.azure.com/microsoft/ProjectReunion/_git/ProjectReunionInternal</Uri>
<Sha>b47c1d3b4a3e2c6b390e93cb133bbd7d83b56ad6</Sha>
Expand Down