Adress Public API review comments#2106
Merged
hulumane merged 4 commits intofeature/WNP_ToastNotifications_L1from Feb 17, 2022
Merged
Adress Public API review comments#2106hulumane merged 4 commits intofeature/WNP_ToastNotifications_L1from
hulumane merged 4 commits intofeature/WNP_ToastNotifications_L1from
Conversation
ghost
added
the
hulumane
requested review from
danielayala94,
jonwis,
loneursid,
pmpurifoy and
sharath2727
loneursid
added
the
area-Notifications
loneursid
reviewed
Feb 16, 2022
sharath2727
reviewed
Feb 16, 2022
pmpurifoy
reviewed
Feb 16, 2022
hulumane
force-pushed
the
user/pavanh/rename-part2
branch
from
a9c3478 to
313807d
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pmpurifoy
approved these changes
Feb 16, 2022
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
loneursid
reviewed
Feb 17, 2022
| winrt::Windows::Foundation::IAsyncAction RemoveWithTagAsync(hstring const tag); | ||
| winrt::Windows::Foundation::IAsyncAction RemoveWithTagGroupAsync(hstring const tag, hstring const group); | ||
| winrt::Windows::Foundation::IAsyncAction RemoveGroupAsync(hstring const group); | ||
| winrt::Windows::Foundation::IAsyncAction RemoveByTagAsync(hstring tag); |
Contributor
There was a problem hiding this comment.
Why are we losing the constness?
Member
Author
There was a problem hiding this comment.
Wasn't on purpose. I promise :)
Member
Author
There was a problem hiding this comment.
I'll send a new PR out addressing this in a bit.
loneursid
approved these changes
Feb 17, 2022
ChrisGuzak
reviewed
Mar 1, 2022
| std::wstring subKey{ c_appIdentifierPath + ConvertPathToKey(wideStringProcessName) }; | ||
|
|
||
| wil::unique_hkey hKey; | ||
| THROW_IF_FAILED(RegCreateKeyEx( |
Member
There was a problem hiding this comment.
RegCreateKeyEx returns a Win32 error code, not an HRESULT, so this is a bug. use THROW_IF_WIN32_ERROR
|
|
||
| WCHAR registeredGuidBuffer[GUID_LENGTH]; | ||
| DWORD bufferLength = sizeof(registeredGuidBuffer); | ||
| HRESULT status = RegGetValueW( |
Member
There was a problem hiding this comment.
RegGetValueW returns a win32 error code, not an HRESULT. use the correct type.
also, status sounds like NTSTATUS, use hr or result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a bunch of comments that came out of the Public API review process