Conversation
ghost
added
the
BenJKuhn
reviewed
Feb 16, 2022
BenJKuhn
reviewed
Feb 16, 2022
BenJKuhn
reviewed
Feb 16, 2022
BenJKuhn
reviewed
Feb 16, 2022
riverar
reviewed
Feb 17, 2022
DrusTheAxe
previously requested changes
Feb 17, 2022
DrusTheAxe
reviewed
Feb 17, 2022
DrusTheAxe
reviewed
Feb 17, 2022
Contributor
Author
|
I did leave a TODO in the spec on purpose. I'm still looking into forbidden interface changes. However, everything else can be reviewed. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jevansaks
reviewed
Mar 3, 2022
DrusTheAxe
reviewed
Mar 4, 2022
DrusTheAxe
reviewed
Mar 4, 2022
DrusTheAxe
reviewed
Mar 4, 2022
DrusTheAxe
reviewed
Mar 4, 2022
jonwis
reviewed
Mar 7, 2022
Contributor
Author
|
@DrusTheAxe I believe I have addressed your comments. |
DrusTheAxe
reviewed
Mar 10, 2022
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DefaultRyan
approved these changes
Mar 16, 2022
Member
|
Couple of minor nits, but I believe this works. Let's check it in. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding documentation got API contracts.