Set icon before running the unpackaged-scenario tests#2129
Merged
danielayala94 merged 1 commit intofeature/WNP_ToastNotifications_L1from Feb 18, 2022
Merged
Set icon before running the unpackaged-scenario tests#2129danielayala94 merged 1 commit intofeature/WNP_ToastNotifications_L1from
danielayala94 merged 1 commit intofeature/WNP_ToastNotifications_L1from
Conversation
danielayala94
requested review from
David-Quero,
hulumane,
loneursid,
pmpurifoy and
sharath2727
ghost
added
the
hulumane
reviewed
Feb 18, 2022
hulumane
approved these changes
Feb 18, 2022
loneursid
added
the
area-Notifications
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing DisplayName/Icon inference logic broke the Toast unit tests, since now it's mandatory to specify the assets before calling AppNotificationManager::Register().
Ran all Toast tests on SV2 after the fix and using the latest lifted DLL. All tests are passing now.