Modify constructor for AppNotificationProgressData per API review#2148
Merged
hulumane merged 7 commits intofeature/WNP_ToastNotifications_L1from Feb 24, 2022
Merged
Conversation
ghost
added
the
hulumane
requested review from
danielayala94,
loneursid,
pmpurifoy and
sharath2727
loneursid
added
the
area-Notifications
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
loneursid
reviewed
Feb 24, 2022
loneursid
reviewed
Feb 24, 2022
loneursid
reviewed
Feb 24, 2022
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
loneursid
approved these changes
Feb 24, 2022
| { | ||
| AppNotificationProgressData() = default; | ||
|
|
||
| AppNotificationProgressData(uint32_t sequenceNumber); |
There was a problem hiding this comment.
Nit: can we use default parameter here like: AppNotificationProgressData(uint32_t sequenceNumber =1)?
Member
Author
There was a problem hiding this comment.
This would assume that we provide a default constructor in our projections. However, there is no default projection per API review feedback. We only have an overload ctor.
danielayala94
approved these changes
Feb 24, 2022
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per API review feedback, we need a ctor that takes in a sequence number. Sequence number needs to be non-zero and enforced, otherwise we throw.