Change EventArgs to Argument#2182
Merged
hulumane merged 1 commit intofeature/WNP_ToastNotifications_L1from Feb 26, 2022
Merged
Conversation
ghost
added
the
hulumane
requested review from
David-Quero,
danielayala94,
loneursid,
pmpurifoy and
sharath2727
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pmpurifoy
approved these changes
Feb 26, 2022
robertzhou-wpn
approved these changes
Feb 26, 2022
pmpurifoy
added
the
area-Notifications
loneursid
reviewed
Feb 26, 2022
|
|
||
| AppNotificationActivatedEventArgs(winrt::hstring const& arguments, winrt::Windows::Foundation::Collections::IMap<winrt::hstring, winrt::hstring> const& userInput) : m_arguments(arguments), m_userInput(userInput) {}; | ||
| winrt::hstring ActivationArgs() { return m_arguments; }; | ||
| winrt::hstring Argument() { return m_arguments; }; |
Contributor
There was a problem hiding this comment.
Why Argument() singular and not Arguments() plural?
Member
Author
There was a problem hiding this comment.
Because Arguments imply its a vector. Argument implies a singleton.
Member
Author
There was a problem hiding this comment.
Also aligns with what we have in Windows SDK today:
[marshaling_behavior(standard)]
[contract(Windows.Foundation.UniversalApiContract, 1)]
runtimeclass ToastNotificationActionTriggerDetail
{
[contract(Windows.Foundation.UniversalApiContract, 1)]
[interface_name("Windows.UI.Notifications.IToastNotificationActionTriggerDetail", 9445135a-38f3-42f6-96aa-7955b0f03da2)]
{
String Argument{ get; };
Windows.Foundation.Collections.ValueSet UserInput{ get; };
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One more final API change