Add SkipNonexistentTargets param to MSBuild task that calls the GetMrtPackagingOutputs target for referenced projects.#260
Merged
rohanp-msft merged 2 commits intomasterfrom Oct 27, 2020
Conversation
…tPackagingOutputs target for referenced projects.
ghost
added
the
rohanp-msft
requested review from
EHO-makai,
axelandrejs,
huichen123 and
jorvanMS
EHO-makai
approved these changes
Oct 27, 2020
jorvanMS
approved these changes
Oct 27, 2020
axelandrejs
approved these changes
Oct 27, 2020
rohanp-msft
deleted the
user/rohanp/add_SkipNonexistentTargets_param_3
branch
Merged
axelandrejs
added a commit
that referenced
this pull request
Nov 20, 2020
* Add PlatformTarget (#261) * Add SkipNonexistentTargets param to MSBuild task that calls the GetMrtPackagingOutputs target for referenced projects. (#260) * Trial * Build break * C# working * C++ sample * Remove signing * Update to winui preview * Code review feedback * build pipeline * missed a spot * dotnet version * show installed sdk version * Window size and lib location * remove nickname * no install vs Co-authored-by: Hui Chen <huichen@microsoft.com> Co-authored-by: Rohan Palaniappan <35987549+rohanp-msft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Add SkipNonexistentTargets param to MSBuild task that calls the GetMrtPackagingOutputs target for referenced projects.
Issue
The targets file recursively calls the GetMrtPackagingOutputs target on referenced projects (this is done to grab all resources, PRI files, etc., from said projects to incorporate into the PRI file that's being generated in the referencing project). The problem is that the GetMrtPackagingOutputs target doesn't exist in projects that don't use MRTCore.
Solution
To address the issue, simply add SkipNonexistentTargets="true" to the MSBuild task invocation!
How verified
App attached to bug now builds successfully.