Skip to content

Fixing AppNotificationBuilder Properties#3405

Closed
loneursid wants to merge 13 commits intomainfrom
user/erlangl/PropertyBugs
Closed

Fixing AppNotificationBuilder Properties#3405
loneursid wants to merge 13 commits intomainfrom
user/erlangl/PropertyBugs

Conversation

@loneursid
Copy link
Copy Markdown
Contributor

@loneursid loneursid commented Feb 6, 2023

Consistent validation should be applied across all builder APIs, regardless of whether items are set through properties or fluent setters. Properties weren't subject to validation prior to this fix.

Any string provided to these APIs must be properly encoded in the resulting XML document, but not in the properties themselves. This will help to prevent issues with data integrity and ensure that the application functions as intended.

@loneursid loneursid added the area-Notifications Toast notification, badges, Live Tiles, push notifications label Feb 6, 2023
@loneursid loneursid self-assigned this Feb 6, 2023
@loneursid loneursid changed the title Fixing AppNotificationBuilder Arguments property Fixing AppNotificationBuilder Properties Feb 6, 2023
@loneursid
Copy link
Copy Markdown
Contributor Author

/azp run TransportPackage-Foundation-PR

@azure-pipelines
Copy link
Copy Markdown

No pipelines are associated with this pull request.

@loneursid loneursid marked this pull request as ready for review February 24, 2023 22:12
@loneursid loneursid added the bug Something isn't working label Mar 4, 2023
@loneursid
Copy link
Copy Markdown
Contributor Author

/azp run TransportPackage-Foundation-PR

@azure-pipelines
Copy link
Copy Markdown

No pipelines are associated with this pull request.

@bpulliam bpulliam closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Notifications Toast notification, badges, Live Tiles, push notifications bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants