Include STL/CRT libs and headers with LKG to eliminate yvals_core.h static_assert build errors on mismatch#4933

Merged

Scottj1s merged 15 commits intomainfrom

user/sjones/lkg_ucrt

Dec 6, 2024

Member

Scottj1s commented Dec 3, 2024 •

edited

Loading

When PR pipeline build agents take a Visual Studio update, the STL/CRT headers can become out of sync with the LKG toolset, causing this build error:
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\include\yvals_core.h(902,1): Error C2338: static_assert failed: 'error STL1001: Unexpected compiler version, expected MSVC 19.41 or newer.'

This PR:

Ensures that the LKG and STL/CRT are a matched set (with workarounds, http://task.ms/55390787, http://task.ms/55390838)
Publishes binlogs for all operations, restore and build, success or fail (which should be our standard practice)
Renames BuildBinaries to BuildFoundation for clarity

Verified that all DLLs in transport package are still Hybrid CRT linked


          include STL/CRT libs/headers with LKG

c396ce2

Member Author

Scottj1s commented Dec 3, 2024

/azp run

microsoft-github-policy-service bot added the needs-triage label

azure-pipelines bot commented Dec 3, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          add platform

c2d1489

Member Author

Scottj1s commented Dec 3, 2024

/azp run

azure-pipelines bot commented Dec 3, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          opt into internal UCRT

03c6b26

Member Author

Scottj1s commented Dec 3, 2024

/azp run

azure-pipelines bot commented Dec 3, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          opt into undocked settings loaded

Member Author

Scottj1s commented Dec 4, 2024

/azp run

azure-pipelines bot commented Dec 4, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          publish binlogs on failure

98e5a6a

Member Author

Scottj1s commented Dec 4, 2024

/azp run

azure-pipelines bot commented Dec 4, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          use lower case platform for LKG toolset

484332a

Member Author

Scottj1s commented Dec 4, 2024

/azp run

azure-pipelines bot commented Dec 4, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          treat Platform as local to allow override of x86 to win32 for LKG

13c9fd5

Member Author

Scottj1s commented Dec 4, 2024

/azp run

azure-pipelines bot commented Dec 4, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          define GUID_NULL, publish binlog on binary build failure

7fc9666

Member Author

Scottj1s commented Dec 5, 2024

/azp run

azure-pipelines bot commented Dec 5, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          define GUID_NULL another way

15f1459

Member Author

Scottj1s commented Dec 5, 2024

/azp run

azure-pipelines bot commented Dec 5, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          collect binlogs for nuget restores

be79b7b

Member Author

Scottj1s commented Dec 5, 2024

/azp run

Scottj1s requested review from JesseCol, alexlamtest and kythant

December 6, 2024 16:35

kythant approved these changes

View reviewed changes

Scottj1s commented

View reviewed changes

LkgToolset.props

Comment on lines +7 to +8

		<UseInternalMSUniCrtPackage>true</UseInternalMSUniCrtPackage>
		<UndockedSettingsLoaded>true</UndockedSettingsLoaded>

Member Author

Scottj1s Dec 6, 2024

the MsUCRT package requires explicit acknowledgement (opt in, on top of the yml task properties)

Scottj1s commented

View reviewed changes

build/AzurePipelinesTemplates/WindowsAppSDK-BuildMRT-Steps.yml

Comment on lines +24 to +26

+                  includeUCRT: true
+                  ucrtFeedPat: $(System.AccessToken)
+                  platform: $(buildPlatform)

Member Author

Scottj1s Dec 6, 2024

this is the essential change - include the UCRT (STL/CRT libs/headers) along with the tools

JesseCol approved these changes

View reviewed changes

alexlamtest reviewed

View reviewed changes

installer/dev/main.cpp Show resolved Hide resolved

alexlamtest approved these changes

View reviewed changes

Contributor

alexlamtest left a comment

LGTM

Scottj1s merged commit 0d7a920 into main

Scottj1s deleted the user/sjones/lkg_ucrt branch

December 6, 2024 21:34

godlytalias pushed a commit that referenced this pull request


          Include STL/CRT libs and headers with LKG to eliminate yvals_core.h s…

327aae0

…tatic_assert build errors on mismatch (#4933)

* include STL/CRT libs/headers with LKG

* add platform

* opt into internal UCRT

* opt into undocked settings loaded

* publish binlogs on failure

* use lower case platform for LKG toolset

* treat Platform as local to allow override of x86 to win32 for LKG

* define GUID_NULL, publish binlog on binary build failure

* define GUID_NULL another way

* collect binlogs for nuget restores

* fix restore binlog name

* nuget restore with platform for LKG compat, renamed BuildBinaries to BuildFoundation for clarity

* setting platform to win32 has downstream effects - surgically wrapping LKG imports instead

* import MsUCRT x86 targets explicitly

* removed unnecessary LKG targets overrides

Scottj1s restored the user/sjones/lkg_ucrt branch

December 13, 2024 22:32

Scottj1s deleted the user/sjones/lkg_ucrt branch

December 13, 2024 22:37

Scottj1s added a commit that referenced this pull request


          Include STL/CRT libs and headers with LKG to eliminate yvals_core.h s…

51758b6

…tatic_assert build errors on mismatch (#4933)

* include STL/CRT libs/headers with LKG

* add platform

* opt into internal UCRT

* opt into undocked settings loaded

* publish binlogs on failure

* use lower case platform for LKG toolset

* treat Platform as local to allow override of x86 to win32 for LKG

* define GUID_NULL, publish binlog on binary build failure

* define GUID_NULL another way

* collect binlogs for nuget restores

* fix restore binlog name

* nuget restore with platform for LKG compat, renamed BuildBinaries to BuildFoundation for clarity

* setting platform to win32 has downstream effects - surgically wrapping LKG imports instead

* import MsUCRT x86 targets explicitly

* removed unnecessary LKG targets overrides

Scottj1s mentioned this pull request

Cherry pick LKG/MsUCRT fixes #4970

Merged

Scottj1s added a commit that referenced this pull request


          Cherry pick LKG/MsUCRT fixes (#4970)

3d7cec3

* Include STL/CRT libs and headers with LKG to eliminate yvals_core.h static_assert build errors on mismatch (#4933)

* include STL/CRT libs/headers with LKG

* add platform

* opt into internal UCRT

* opt into undocked settings loaded

* publish binlogs on failure

* use lower case platform for LKG toolset

* treat Platform as local to allow override of x86 to win32 for LKG

* define GUID_NULL, publish binlog on binary build failure

* define GUID_NULL another way

* collect binlogs for nuget restores

* fix restore binlog name

* nuget restore with platform for LKG compat, renamed BuildBinaries to BuildFoundation for clarity

* setting platform to win32 has downstream effects - surgically wrapping LKG imports instead

* import MsUCRT x86 targets explicitly

* removed unnecessary LKG targets overrides

* Find custom.props in parent dir (#4946)

* Update LkgToolset.props

Fix build break - custom.props in parent directory

* Update LkgToolset.props

codendone pushed a commit that referenced this pull request


          Include STL/CRT libs and headers with LKG to eliminate yvals_core.h s…

785f211

…tatic_assert build errors on mismatch (#4933)

* include STL/CRT libs/headers with LKG

* add platform

* opt into internal UCRT

* opt into undocked settings loaded

* publish binlogs on failure

* use lower case platform for LKG toolset

* treat Platform as local to allow override of x86 to win32 for LKG

* define GUID_NULL, publish binlog on binary build failure

* define GUID_NULL another way

* collect binlogs for nuget restores

* fix restore binlog name

* nuget restore with platform for LKG compat, renamed BuildBinaries to BuildFoundation for clarity

* setting platform to win32 has downstream effects - surgically wrapping LKG imports instead

* import MsUCRT x86 targets explicitly

* removed unnecessary LKG targets overrides

This was referenced Dec 18, 2025

Bump Microsoft.WindowsAppSDK from 1.6.241114003 to 1.8.251106002 oppis/EDIViewer#21

Closed

Bump Microsoft.WindowsAppSDK from 1.6.250108002 to 1.8.251106002 shibayan/WindowsAppSDK-Boilerplate#41

Closed

Bump Microsoft.WindowsAppSDK from 1.6.250108002 to 1.8.251106002 WinUI-Dev/TranslateUI#24

Closed

This was referenced Jan 14, 2026

Bump Microsoft.WindowsAppSDK from 1.6.241114003 to 1.8.260101001 oppis/EDIViewer#22

Closed

Bump Microsoft.WindowsAppSDK from 1.6.250108002 to 1.8.260101001 shibayan/WindowsAppSDK-Boilerplate#42

Merged

Bump Microsoft.WindowsAppSDK from 1.6.250108002 to 1.8.260101001 WinUI-Dev/TranslateUI#25

Closed

This was referenced Jan 26, 2026

Bump Microsoft.WindowsAppSDK from 1.6.250108002 to 1.8.260101001 shibayan/WindowsAppSDK-Boilerplate#43

Merged

Bump Microsoft.WindowsAppSDK from 1.6.250108002 to 1.8.260101001 shibayan/WindowsAppSDK-Boilerplate#44

Merged

This was referenced Feb 9, 2026

Bump Microsoft.WindowsAppSDK from 1.6.250108002 to 1.8.260101001 martial-plains/disk-detect-windows#7

Merged

Bump Microsoft.WindowsAppSDK from 1.6.241114003 to 1.8.260209005 oppis/EDIViewer#23

Closed

dependabot bot mentioned this pull request

Bump Microsoft.WindowsAppSDK from 1.6.250108002 to 1.8.260209005 WinUI-Dev/TranslateUI#26

Open

dependabot bot mentioned this pull request

Bump Microsoft.WindowsAppSDK from 1.6.241114003 to 1.8.260317003 oppis/EDIViewer#27

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels