Skip to content

Fix signing in ADO pipeline#193

Merged
spadapet merged 2 commits intomainfrom
dev/peterspa/FixSigningOrder
Feb 25, 2026
Merged

Fix signing in ADO pipeline#193
spadapet merged 2 commits intomainfrom
dev/peterspa/FixSigningOrder

Conversation

@spadapet
Copy link
Copy Markdown
Member

Description of Change

Signing was hanging, probably due to the order of MicroBuildSigningPlugin vs the build tasks. This PR will make the pipeline act more like the working UWP pipeline:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Azure DevOps pipeline signing setup to avoid hangs by aligning task ordering with the known-working MicroBuild-based flow.

Changes:

  • Moves MicroBuildSigningPlugin@4 earlier in the job so signing is initialized before build/test steps.
  • Removes explicit VS version wiring (BuildParameters.vsVersion and vsVersion task inputs).
  • Adjusts the first VSBuild invocation (MSBuild args and cleaning behavior).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@spadapet spadapet merged commit 46b6a6a into main Feb 25, 2026
9 checks passed
@spadapet spadapet deleted the dev/peterspa/FixSigningOrder branch February 25, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants