.NET: Seal options and context classes#2633
Merged
SergeyMenshykh merged 2 commits intomicrosoft:mainfrom Dec 4, 2025
Merged
Conversation
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
markwallace-microsoft
approved these changes
Dec 4, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR seals three classes that are not intended for inheritance, improving code clarity and following best practices for C# class design.
- Sealed
ChatClientAgentOptionsclass to prevent unintended inheritance - Sealed
InvokingContextandInvokedContextnested classes withinAIContextProviderto clarify they are not meant to be extended
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI/ChatClient/ChatClientAgentOptions.cs | Sealed ChatClientAgentOptions class to prevent inheritance |
| dotnet/src/Microsoft.Agents.AI.Abstractions/AIContextProvider.cs | Sealed nested InvokingContext and InvokedContext classes to prevent inheritance |
rogerbarreto
approved these changes
Dec 4, 2025
rogerbarreto
temporarily deployed
to
integration
GitHub Actions
Inactive
rogerbarreto
had a problem deploying
to
integration
GitHub Actions
Failure
westey-m
approved these changes
Dec 4, 2025
rogerbarreto
temporarily deployed
to
integration
GitHub Actions
Inactive
61 tasks
This was referenced Dec 5, 2025
This was referenced Dec 22, 2025
This was referenced Jan 9, 2026
This was referenced Jan 19, 2026
This was referenced Jan 28, 2026
arisng
pushed a commit
to arisng/agent-framework
that referenced
this pull request
Feb 2, 2026
Co-authored-by: Roger Barreto <19890735+rogerbarreto@users.noreply.github.com>
This was referenced Mar 2, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to: #2542