chore: revert - Default deployment mode to "standard" instead of "workshop"#221
Draft
Pavan-Microsoft wants to merge 8 commits intodevfrom
Draft
chore: revert - Default deployment mode to "standard" instead of "workshop"#221Pavan-Microsoft wants to merge 8 commits intodevfrom
Pavan-Microsoft wants to merge 8 commits intodevfrom
Conversation
- Deleted 02_upload_documents.py and its requirements as they are no longer needed. - Removed run_search_index_scripts.sh and related SQL item scripts to streamline the deployment process. - Updated run_workshop_data_setup.sh to reflect changes in environment variable handling and removed unnecessary parameters. - Cleaned up create_sql_items.py by removing unused imports and functions. - Updated documentation to clarify workshop mode setup and deployment instructions. - Added IS_WORKSHOP and AZURE_ENV_DEPLOY_APP flags to .env.sample for better configuration management.
…update deployment guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates both the deployment configuration and the agent creation script to simplify deployment modes, improve tagging, and streamline agent instructions. The changes remove the distinction between "workshop" and "standard" deployments in several places, default deployments to "standard" mode, and improve resource tagging in the infrastructure code.
Deployment configuration and resource tagging:
isWorkshopare now set tofalse. [1] [2] [3] [4]tagsparameter is now enabled and used throughout the Bicep and generated ARM templates. [1] [2] [3] [4] [5] [6] [7] [8]backendRuntimeStackandusecaseparameters have been removed, requiring explicit values during deployment. [1] [2] [3]Agent creation script simplification:
01_create_agents.py) is refactored to remove all logic and instructions related to the "workshop" deployment mode, consolidating to a single set of agent instructions. The script no longer accepts or checks foris_workshop, and the tools and instructions are simplified. [1] [2] [3] [4]Documentation update:
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation