Skip to content

Review use of ArgumentException/ArgumentNullException in all public APIs #2649

@DamianEdwards

Description

@DamianEdwards

I noticed we seem to have lots of public APIs that accept reference type parameters not marked as nullable but then don't check that they're actually non-null and throw an ArgumentNullException when necessary. We should decide what we're doing and review all public APIs for appropriate argument validation.

e.g. https://github.com/dotnet/aspire/blob/240cde74a83cc5378a90c2b6eeb8d65f43658d80/src/Aspire.Hosting/Extensions/ResourceBuilderExtensions.cs#L92-L98

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-app-modelIssues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplicationgood first issueGood for newcomershelp wantedIssue that is a good candidate for community contribution.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions